Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 039f935a authored by Artemii Karasev's avatar Artemii Karasev Committed by Greg Kroah-Hartman
Browse files

ALSA: emux: Avoid potential array out-of-bound in snd_emux_xg_control() 



commit 6a32425f953b955b4ff82f339d01df0b713caa5d upstream.

snd_emux_xg_control() can be called with an argument 'param' greater
than size of 'control' array. It may lead to accessing 'control'
array at a wrong index.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Signed-off-by: default avatarArtemii Karasev <karasev@ispras.ru>
Fixes: 1da177e4 ("Linux-2.6.12-rc2")
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20230207132026.2870-1-karasev@ispras.ru


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 7e43bb69

sound/synth/emux/emux_nrpn.c

+3 −0
Original line number Diff line number Diff line
@@ -349,6 +349,9 @@ int 
snd_emux_xg_control(struct snd_emux_port *port, struct snd_midi_channel *chan,

		    int param)

{

	if (param >= ARRAY_SIZE(chan->control))

		return -EINVAL;



	return send_converted_effect(xg_effects, ARRAY_SIZE(xg_effects),

				     port, chan, param,

				     chan->control[param],