Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 038dab7e authored Aug 21, 2019 by Markus Elfring Committed by David S. Miller Aug 22, 2019

can: Delete unnecessary checks before the macro call “dev_kfree_skb”



The dev_kfree_skb() function performs also input parameter validation.
Thus the test around the shown calls is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Acked-by: Sean Nyekjaer <sean@geanix.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 0f817a5e

drivers/net/can/spi/hi311x.c

+1 −2

Original line number	Original line	Diff line number	Diff line
	@@ -177,7 +177,6 @@ static void hi3110_clean(struct net_device *net)

	if (priv->tx_skb \|\| priv->tx_len)		if (priv->tx_skb \|\| priv->tx_len)
	net->stats.tx_errors++;		net->stats.tx_errors++;
	if (priv->tx_skb)
	dev_kfree_skb(priv->tx_skb);		dev_kfree_skb(priv->tx_skb);
	if (priv->tx_len)		if (priv->tx_len)
	can_free_echo_skb(priv->net, 0);		can_free_echo_skb(priv->net, 0);

drivers/net/can/spi/mcp251x.c

+1 −2

Original line number	Original line	Diff line number	Diff line
	@@ -264,7 +264,6 @@ static void mcp251x_clean(struct net_device *net)

	if (priv->tx_skb \|\| priv->tx_len)		if (priv->tx_skb \|\| priv->tx_len)
	net->stats.tx_errors++;		net->stats.tx_errors++;
	if (priv->tx_skb)
	dev_kfree_skb(priv->tx_skb);		dev_kfree_skb(priv->tx_skb);
	if (priv->tx_len)		if (priv->tx_len)
	can_free_echo_skb(priv->net, 0);		can_free_echo_skb(priv->net, 0);