Unverified Commit 0357a3da authored Jan 10, 2019 by Stephen Boyd Committed by Mark Brown Jan 14, 2019

spi: spi-geni-qcom: Don't initialize completion for normal message

We only use this completion when we're doing something that isn't a
message transfer. For example, changing CS or aborting/canceling a
command. All of those situations properly reinitialize the completion
before sending the GENI the special command to change CS or cancel, etc.
Given that, let's remove the initialization here.

Cc: Girish Mahadevan <girishm@codeaurora.org>
Cc: Dilip Kota <dkota@codeaurora.org>
Cc: Alok Chauhan <alokc@codeaurora.org>
Cc: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
Signed-off-by: Mark Brown <broonie@kernel.org>

parent 74fa750e

drivers/spi/spi-geni-qcom.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -233,7 +233,6 @@ static int spi_geni_prepare_message(struct spi_master *spi,
		struct geni_se *se = &mas->se;

		geni_se_select_mode(se, GENI_SE_FIFO);
		reinit_completion(&mas->xfer_done);
		ret = setup_fifo_params(spi_msg->spi, spi);
		if (ret)
		dev_err(mas->dev, "Couldn't select mode %d\n", ret);