Commit 03531482 authored Feb 09, 2019 by Zephaniah E. Loss-Cutler-Hull Committed by Len Brown Aug 31, 2019

tools/power x86_energy_perf_policy: Fix argument parsing



The -w argument in x86_energy_perf_policy currently triggers an
unconditional segfault.

This is because the argument string reads: "+a:c:dD:E:e:f:m:M:rt:u:vw" and
yet the argument handler expects an argument.

When parse_optarg_string is called with a null argument, we then proceed to
crash in strncmp, not horribly friendly.

The man page describes -w as taking an argument, the long form
(--hwp-window) is correctly marked as taking a required argument, and the
code expects it.

As such, this patch simply marks the short form (-w) as requiring an
argument.

Signed-off-by: Zephaniah E. Loss-Cutler-Hull <zephaniah@gmail.com>
Signed-off-by: Len Brown <len.brown@intel.com>

parent f3fe116a

tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -545,7 +545,7 @@ void cmdline(int argc, char **argv)

		progname = argv[0];

		while ((opt = getopt_long_only(argc, argv, "+a:c:dD:E:e:f:m:M:rt:u:vw",
		while ((opt = getopt_long_only(argc, argv, "+a:c:dD:E:e:f:m:M:rt:u:vw:",
		long_options, &option_index)) != -1) {
		switch (opt) {
		case 'a':