Commit 033864b0 authored Sep 17, 2020 by Fernando Pacheco

msm: camera: icp: Fix potential deadlock scenario in cam_hfi_init



Make sure we perform the necessary unlock operations before we return
on an invalid HFI state.

CRs-Fixed: 2783934
Change-Id: I7c611fb98d245952f2f4e9a57dc5fcb249572a40
Signed-off-by: Fernando Pacheco <fpacheco@codeaurora.org>

parent a2fdf71a

drivers/cam_icp/hfi.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -647,7 +647,8 @@ int cam_hfi_init(struct hfi_mem_info hfi_mem, const struct hfi_ops hfi_ops,

		if (g_hfi->hfi_state != HFI_DEINIT) {
		CAM_ERR(CAM_HFI, "hfi_init: invalid state");
		return -EINVAL;
		rc = -EINVAL;
		goto regions_fail;
		}

		memcpy(&g_hfi->map, hfi_mem, sizeof(g_hfi->map));