Commit 031fda28 authored Apr 29, 2022 by Miaoqian Lin Committed by Greg Kroah-Hartman May 18, 2022

slimbus: qcom: Fix IRQ check in qcom_slim_probe



commit fe503887eed6ea528e144ec8dacfa1d47aa701ac upstream.

platform_get_irq() returns non-zero IRQ number on success,
negative error number on failure.
And the doc of platform_get_irq() provides a usage example:

    int irq = platform_get_irq(pdev, 0);
    if (irq < 0)
        return irq;

Fix the check of return value to catch errors correctly.

Fixes: ad7fcbc3 ("slimbus: qcom: Add Qualcomm Slimbus controller driver")
Cc: stable@vger.kernel.org
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Link: https://lore.kernel.org/r/20220429164917.5202-2-srinivas.kandagatla@linaro.org


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 7de6f305

drivers/slimbus/qcom-ctrl.c

+2 −2

Original line number	Original line	Diff line number	Diff line
	@@ -515,9 +515,9 @@ static int qcom_slim_probe(struct platform_device *pdev)
	}		}

	ctrl->irq = platform_get_irq(pdev, 0);		ctrl->irq = platform_get_irq(pdev, 0);
	if (!ctrl->irq) {		if (ctrl->irq < 0) {
	dev_err(&pdev->dev, "no slimbus IRQ\n");		dev_err(&pdev->dev, "no slimbus IRQ\n");
	return -ENODEV;		return ctrl->irq;
	}		}

	sctrl = &ctrl->ctrl;		sctrl = &ctrl->ctrl;