Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 02d62d6d authored by Namhyung Kim's avatar Namhyung Kim Committed by Arnaldo Carvalho de Melo
Browse files

tools lib traceevent: Get rid of die() in add_right() 



Refactor it to return appropriate pevent_errno value.

Signed-off-by: default avatarNamhyung Kim <namhyung@kernel.org>
Reviewed-by: default avatarSteven Rostedt <rostedt@goodmis.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung.kim@lge.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Steven Rostedt <rostedt@goodmis.org>
Link: http://lkml.kernel.org/r/1386833777-3790-7-git-send-email-namhyung@kernel.org


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 605b8fda

tools/lib/traceevent/event-parse.h

+7 −1
Original line number Diff line number Diff line
@@ -358,7 +358,13 @@ enum pevent_flag { 
	_PE(OLD_FTRACE_ARG_FAILED,"failed to allocate field name for ftrace"),\

	_PE(INVALID_ARG_TYPE,	"invalid argument type"),		      \

	_PE(INVALID_EVENT_NAME,	"invalid event name"),			      \

	_PE(EVENT_NOT_FOUND,	"No event found")

	_PE(EVENT_NOT_FOUND,	"no event found"),			      \

	_PE(SYNTAX_ERROR,	"syntax error"),			      \

	_PE(ILLEGAL_RVALUE,	"illegal rvalue"),			      \

	_PE(ILLEGAL_LVALUE,	"illegal lvalue for string comparison"),      \

	_PE(INVALID_REGEX,	"regex did not compute"),		      \

	_PE(ILLEGAL_STRING_CMP,	"illegal comparison for string"), 	      \

	_PE(ILLEGAL_INTEGER_CMP,"illegal comparison for integer")



#undef _PE

#define _PE(__code, __str) PEVENT_ERRNO__ ## __code

tools/lib/traceevent/parse-filter.c

+19 −15
Original line number Diff line number Diff line
@@ -473,8 +473,8 @@ create_arg_cmp(enum filter_exp_type etype) 
	return arg;

}



static int add_right(struct filter_arg *op, struct filter_arg *arg,

		     char **error_str)

static enum pevent_errno

add_right(struct filter_arg *op, struct filter_arg *arg, char **error_str)

{

	struct filter_arg *left;

	char *str;
@@ -505,9 +505,8 @@ static int add_right(struct filter_arg *op, struct filter_arg *arg, 
		case FILTER_ARG_FIELD:

			break;

		default:

			show_error(error_str,

				   "Illegal rvalue");

			return -1;

			show_error(error_str, "Illegal rvalue");

			return PEVENT_ERRNO__ILLEGAL_RVALUE;

		}



		/*
@@ -554,7 +553,7 @@ static int add_right(struct filter_arg *op, struct filter_arg *arg, 
			if (left->type != FILTER_ARG_FIELD) {

				show_error(error_str,

					   "Illegal lvalue for string comparison");

				return -1;

				return PEVENT_ERRNO__ILLEGAL_LVALUE;

			}



			/* Make sure this is a valid string compare */
@@ -573,25 +572,31 @@ static int add_right(struct filter_arg *op, struct filter_arg *arg, 
					show_error(error_str,

						   "RegEx '%s' did not compute",

						   str);

					return -1;

					return PEVENT_ERRNO__INVALID_REGEX;

				}

				break;

			default:

				show_error(error_str,

					   "Illegal comparison for string");

				return -1;

				return PEVENT_ERRNO__ILLEGAL_STRING_CMP;

			}



			op->type = FILTER_ARG_STR;

			op->str.type = op_type;

			op->str.field = left->field.field;

			op->str.val = strdup(str);

			if (!op->str.val)

				die("malloc string");

			if (!op->str.val) {

				show_error(error_str, "Failed to allocate string filter");

				return PEVENT_ERRNO__MEM_ALLOC_FAILED;

			}

			/*

			 * Need a buffer to copy data for tests

			 */

			op->str.buffer = malloc_or_die(op->str.field->size + 1);

			op->str.buffer = malloc(op->str.field->size + 1);

			if (!op->str.buffer) {

				show_error(error_str, "Failed to allocate string filter");

				return PEVENT_ERRNO__MEM_ALLOC_FAILED;

			}

			/* Null terminate this buffer */

			op->str.buffer[op->str.field->size] = 0;
@@ -609,7 +614,7 @@ static int add_right(struct filter_arg *op, struct filter_arg *arg, 
			case FILTER_CMP_NOT_REGEX:

				show_error(error_str,

					   "Op not allowed with integers");

				return -1;

				return PEVENT_ERRNO__ILLEGAL_INTEGER_CMP;



			default:

				break;
@@ -629,9 +634,8 @@ static int add_right(struct filter_arg *op, struct filter_arg *arg, 
	return 0;



 out_fail:

	show_error(error_str,

		   "Syntax error");

	return -1;

	show_error(error_str, "Syntax error");

	return PEVENT_ERRNO__SYNTAX_ERROR;

}



static struct filter_arg *