Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 02a9fbfc authored by Scott Feldman's avatar Scott Feldman Committed by David S. Miller
Browse files

rocker: mark neigh update event processing as 'no wait' 



Neigh update event handler runs in a context where we can't sleep, so mark
processing in driver with ROCKER_OP_FLAG_NOWAIT.  NOWAIT will use
GFP_ATOMIC for allocations and will queue cmds to the device's cmd ring but
will not wait (sleep) for cmd response back from device.

Signed-off-by: default avatarScott Feldman <sfeldma@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 179f9a25

drivers/net/ethernet/rocker/rocker.c

+2 −1
Original line number Original line Diff line number Diff line
@@ -5251,7 +5251,8 @@ static struct notifier_block rocker_netdevice_nb __read_mostly = { 
static int rocker_neigh_update(struct net_device *dev, struct neighbour *n)

static int rocker_neigh_update(struct net_device *dev, struct neighbour *n)

{

{

	struct rocker_port *rocker_port = netdev_priv(dev);

	struct rocker_port *rocker_port = netdev_priv(dev);

	int flags = (n->nud_state & NUD_VALID) ? 0 : ROCKER_OP_FLAG_REMOVE;

	int flags = (n->nud_state & NUD_VALID ? 0 : ROCKER_OP_FLAG_REMOVE) |

		    ROCKER_OP_FLAG_NOWAIT;

	__be32 ip_addr = *(__be32 *)n->primary_key;

	__be32 ip_addr = *(__be32 *)n->primary_key;





	return rocker_port_ipv4_neigh(rocker_port, SWITCHDEV_TRANS_NONE,

	return rocker_port_ipv4_neigh(rocker_port, SWITCHDEV_TRANS_NONE,