Commit 026441f5 authored Jun 20, 2022 by Hyunwoo Kim Committed by Treehugger Robot Nov 08, 2022

UPSTREAM: video: fbdev: pxa3xx-gcu: Fix integer overflow in pxa3xx_gcu_write



[ Upstream commit a09d2d00af53b43c6f11e6ab3cb58443c2cac8a7 ]

In pxa3xx_gcu_write, a count parameter of type size_t is passed to words of
type int.  Then, copy_from_user() may cause a heap overflow because it is used
as the third argument of copy_from_user().

Bug: 245928838
Signed-off-by: Hyunwoo Kim <imv4bel@gmail.com>
Signed-off-by: Helge Deller <deller@gmx.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Lee Jones <joneslee@google.com>
Change-Id: I9e21917a52e2cb78cc640a77a6eba21838aa8655

parent 482efd77

drivers/video/fbdev/pxa3xx-gcu.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -382,7 +382,7 @@ pxa3xx_gcu_write(struct file file, const char buff,
		struct pxa3xx_gcu_batch *buffer;
		struct pxa3xx_gcu_priv *priv = to_pxa3xx_gcu_priv(file);

		int words = count / 4;
		size_t words = count / 4;

		/* Does not need to be atomic. There's a lock in user space,
		* but anyhow, this is just for statistics. */