Commit 025ec40b authored Nov 07, 2019 by Pan Bian Committed by David S. Miller Nov 07, 2019

nfc: netlink: fix double device reference drop



The function nfc_put_device(dev) is called twice to drop the reference
to dev when there is no associated local llcp. Remove one of them to fix
the bug.

Fixes: 52feb444 ("NFC: Extend netlink interface for LTO, RW, and MIUX parameters support")
Fixes: d9b8d8e1 ("NFC: llcp: Service Name Lookup netlink interface")
Signed-off-by: Pan Bian <bianpan2016@163.com>
Reviewed-by: Johan Hovold <johan@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 99a8efbb

net/nfc/netlink.c

+0 −2

Original line number	Original line	Diff line number	Diff line
	@@ -1099,7 +1099,6 @@ static int nfc_genl_llc_set_params(struct sk_buff skb, struct genl_info info)

	local = nfc_llcp_find_local(dev);		local = nfc_llcp_find_local(dev);
	if (!local) {		if (!local) {
	nfc_put_device(dev);
	rc = -ENODEV;		rc = -ENODEV;
	goto exit;		goto exit;
	}		}
	@@ -1159,7 +1158,6 @@ static int nfc_genl_llc_sdreq(struct sk_buff skb, struct genl_info info)

	local = nfc_llcp_find_local(dev);		local = nfc_llcp_find_local(dev);
	if (!local) {		if (!local) {
	nfc_put_device(dev);
	rc = -ENODEV;		rc = -ENODEV;
	goto exit;		goto exit;
	}		}