Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 02416142 authored by Yishai Hadas's avatar Yishai Hadas Committed by Greg Kroah-Hartman
Browse files

RDMA/mlx5: Fix udata response upon SRQ creation 

[ Upstream commit cf26deff9036cd3270af562dbec545239e5c7f07 ]

Fix udata response upon SRQ creation to use the UAPI structure (i.e.
mlx5_ib_create_srq_resp). It did not zero the reserved field in userspace.

Fixes: e126ba97 ("mlx5: Add driver for Mellanox Connect-IB adapters")
Link: https://lore.kernel.org/r/20200406173540.1466477-1-leon@kernel.org


Signed-off-by: default avatarYishai Hadas <yishaih@mellanox.com>
Signed-off-by: default avatarLeon Romanovsky <leonro@mellanox.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@mellanox.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 7acbadd1

drivers/infiniband/hw/mlx5/srq.c

+8 −2
Original line number Diff line number Diff line
@@ -310,12 +310,18 @@ int mlx5_ib_create_srq(struct ib_srq *ib_srq, 
	srq->msrq.event = mlx5_ib_srq_event;

	srq->ibsrq.ext.xrc.srq_num = srq->msrq.srqn;



	if (udata)

		if (ib_copy_to_udata(udata, &srq->msrq.srqn, sizeof(__u32))) {

	if (udata) {

		struct mlx5_ib_create_srq_resp resp = {

			.srqn = srq->msrq.srqn,

		};



		if (ib_copy_to_udata(udata, &resp, min(udata->outlen,

				     sizeof(resp)))) {

			mlx5_ib_dbg(dev, "copy to user failed\n");

			err = -EFAULT;

			goto err_core;

		}

	}



	init_attr->attr.max_wr = srq->msrq.max - 1;