Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0226926b authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Greg Kroah-Hartman
Browse files

firmware: ti_sci: Fix an off-by-one in ti_sci_debugfs_create() 



[ Upstream commit 964946b88887089f447a9b6a28c39ee97dc76360 ]

The ending NULL is not taken into account by strncat(), so switch to
snprintf() to correctly build 'debug_name'.

Using snprintf() also makes the code more readable.

Fixes: aa276781 ("firmware: Add basic support for TI System Control Interface (TI-SCI) protocol")
Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/7158db0a4d7b19855ddd542ec61b666973aad8dc.1698660720.git.christophe.jaillet@wanadoo.fr


Signed-off-by: default avatarNishanth Menon <nm@ti.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent ef75f3c5

drivers/firmware/ti_sci.c

+5 −5
Original line number Diff line number Diff line
@@ -179,7 +179,7 @@ static int ti_sci_debugfs_create(struct platform_device *pdev, 
{

	struct device *dev = &pdev->dev;

	struct resource *res;

	char debug_name[50] = "ti_sci_debug@";

	char debug_name[50];



	/* Debug region is optional */

	res = platform_get_resource_byname(pdev, IORESOURCE_MEM,
@@ -196,10 +196,10 @@ static int ti_sci_debugfs_create(struct platform_device *pdev, 
	/* Setup NULL termination */

	info->debug_buffer[info->debug_region_size] = 0;



	info->d = debugfs_create_file(strncat(debug_name, dev_name(dev),

					      sizeof(debug_name) -

					      sizeof("ti_sci_debug@")),

				      0444, NULL, info, &ti_sci_debug_fops);

	snprintf(debug_name, sizeof(debug_name), "ti_sci_debug@%s",

		 dev_name(dev));

	info->d = debugfs_create_file(debug_name, 0444, NULL, info,

				      &ti_sci_debug_fops);

	if (IS_ERR(info->d))

		return PTR_ERR(info->d);