Commit 01e6885b authored Oct 31, 2023 by Hangyu Hua Committed by Greg Kroah-Hartman Nov 08, 2023

rpmsg: Fix possible refcount leak in rpmsg_register_device_override()



commit d7bd416d35121c95fe47330e09a5c04adbc5f928 upstream.

rpmsg_register_device_override need to call put_device to free vch when
driver_set_override fails.

Fix this by adding a put_device() to the error path.

Fixes: bb17d110cbf2 ("rpmsg: Fix calling device_lock() on non-initialized device")
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
Link: https://lore.kernel.org/r/20220624024120.11576-1-hbh25y@gmail.com


Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Signed-off-by: Lee Jones <lee@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent cff56d7a

drivers/rpmsg/rpmsg_core.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -551,6 +551,7 @@ int rpmsg_register_device_override(struct rpmsg_device *rpdev,
		strlen(driver_override));
		if (ret) {
		dev_err(dev, "device_set_override failed: %d\n", ret);
		put_device(dev);
		return ret;
		}
		}