Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 015496c4 authored Jan 23, 2019 by Gustavo A. R. Silva Committed by David S. Miller Jan 23, 2019

broadcom: Mark expected switch fall-throughs



In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

This patch fixes the following warnings:

drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c:6336:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c:2231:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
drivers/net/ethernet/broadcom/tg3.c:722:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
drivers/net/ethernet/broadcom/tg3.c:783:6: warning: this statement may fall through [-Wimplicit-fallthrough=]

Warning level 3 was used: -Wimplicit-fallthrough=3

This patch is part of the ongoing efforts to enabling
-Wimplicit-fallthrough.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Acked-by: Sudarsana Kalluru <Sudarsana.Kalluru@cavium.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent d422a286

drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -6335,7 +6335,7 @@ int bnx2x_set_led(struct link_params *params,
		*/
		if (!vars->link_up)
		break;
		/* else: fall through */
		/* fall through */
		case LED_MODE_ON:
		if (((params->phy[EXT_PHY1].type ==
		PORT_HW_CFG_XGXS_EXT_PHY_TYPE_BCM8727) \|\|

drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2230,7 +2230,7 @@ int bnx2x_vf_free(struct bnx2x bp, struct bnx2x_virtf vf)
		rc = bnx2x_vf_close(bp, vf);
		if (rc)
		goto op_err;
		/* Fallthrough to release resources */
		/* Fall through - to release resources */
		case VF_ACQUIRED:
		DP(BNX2X_MSG_IOV, "about to free resources\n");
		bnx2x_vf_free_resc(bp, vf);

drivers/net/ethernet/broadcom/tg3.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -721,7 +721,7 @@ static int tg3_ape_lock(struct tg3 *tp, int locknum)
		case TG3_APE_LOCK_GPIO:
		if (tg3_asic_rev(tp) == ASIC_REV_5761)
		return 0;
		/* else: fall through */
		/* fall through */
		case TG3_APE_LOCK_GRC:
		case TG3_APE_LOCK_MEM:
		if (!tp->pci_fn)
		@@ -782,7 +782,7 @@ static void tg3_ape_unlock(struct tg3 *tp, int locknum)
		case TG3_APE_LOCK_GPIO:
		if (tg3_asic_rev(tp) == ASIC_REV_5761)
		return;
		/* else: fall through */
		/* fall through */
		case TG3_APE_LOCK_GRC:
		case TG3_APE_LOCK_MEM:
		if (!tp->pci_fn)