Commit 00d58d0b authored Nov 19, 2019 by Herbert Xu Committed by Greg Kroah-Hartman Feb 01, 2020

crypto: pcrypt - Fix user-after-free on module unload



commit 07bfd9bdf568a38d9440c607b72342036011f727 upstream.

On module unload of pcrypt we must unregister the crypto algorithms
first and then tear down the padata structure.  As otherwise the
crypto algorithms are still alive and can be used while the padata
structure is being freed.

Fixes: 5068c7a8 ("crypto: pcrypt - Add pcrypt crypto...")
Cc: <stable@vger.kernel.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 9f6d555f

crypto/pcrypt.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -362,11 +362,12 @@ static int __init pcrypt_init(void)

		static void __exit pcrypt_exit(void)
		{
		crypto_unregister_template(&pcrypt_tmpl);

		pcrypt_fini_padata(pencrypt);
		pcrypt_fini_padata(pdecrypt);

		kset_unregister(pcrypt_kset);
		crypto_unregister_template(&pcrypt_tmpl);
		}

		subsys_initcall(pcrypt_init);