Commit 004fbb04 authored Jan 11, 2023 by Prashant Malani Committed by Greg Kroah-Hartman Jan 24, 2023

usb: typec: altmodes/displayport: Fix pin assignment calculation



commit 9682b41e52cc9f42f5c33caf410464392adaef04 upstream.

Commit c1e5c2f0cb8a ("usb: typec: altmodes/displayport: correct pin
assignment for UFP receptacles") fixed the pin assignment calculation
to take into account whether the peripheral was a plug or a receptacle.

But the "pin_assignments" sysfs logic was not updated. Address this by
using the macros introduced in the aforementioned commit in the sysfs
logic too.

Fixes: c1e5c2f0cb8a ("usb: typec: altmodes/displayport: correct pin assignment for UFP receptacles")
Cc: stable@vger.kernel.org
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Signed-off-by: Prashant Malani <pmalani@chromium.org>
Reviewed-by: Benson Leung <bleung@chromium.org>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Link: https://lore.kernel.org/r/20230111020546.3384569-2-pmalani@chromium.org


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent a1478ef5

drivers/usb/typec/altmodes/displayport.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -414,9 +414,9 @@ static const char * const pin_assignments[] = {
		static u8 get_current_pin_assignments(struct dp_altmode *dp)
		{
		if (DP_CONF_CURRENTLY(dp->data.conf) == DP_CONF_DFP_D)
		return DP_CAP_UFP_D_PIN_ASSIGN(dp->alt->vdo);
		return DP_CAP_PIN_ASSIGN_DFP_D(dp->alt->vdo);
		else
		return DP_CAP_DFP_D_PIN_ASSIGN(dp->alt->vdo);
		return DP_CAP_PIN_ASSIGN_UFP_D(dp->alt->vdo);
		}

		static ssize_t