Commit 00492f82 authored Nov 19, 2022 by Yang Yingliang Committed by Greg Kroah-Hartman Dec 08, 2022

Drivers: hv: vmbus: fix possible memory leak in vmbus_device_register()



[ Upstream commit 25c94b051592c010abe92c85b0485f1faedc83f3 ]

If device_register() returns error in vmbus_device_register(),
the name allocated by dev_set_name() must be freed. As comment
of device_register() says, it should use put_device() to give
up the reference in the error path. So fix this by calling
put_device(), then the name can be freed in kobject_cleanup().

Fixes: 09d50ff8 ("Staging: hv: make the Hyper-V virtual bus code build")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Michael Kelley <mikelley@microsoft.com>
Link: https://lore.kernel.org/r/20221119081135.1564691-3-yangyingliang@huawei.com


Signed-off-by: Wei Liu <wei.liu@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent e0d5beca

drivers/hv/vmbus_drv.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -1863,6 +1863,7 @@ int vmbus_device_register(struct hv_device *child_device_obj)
		ret = device_register(&child_device_obj->device);
		if (ret) {
		pr_err("Unable to register child device\n");
		put_device(&child_device_obj->device);
		return ret;
		}