Commit 0007fa36 authored Jun 12, 2015 by Uwe Kleine-König Committed by Sebastian Reichel Jun 13, 2015

power_supply: bq25890: use flags argument of devm_gpiod_get

Since 39b2bbe3 (gpio: add flags argument to gpiod_get*() functions)
which appeared in v3.17-rc1, the gpiod_get* functions take an additional
parameter that allows to specify direction and initial value for output.

Simplify driver accordingly. Furthermore this is one caller less that
stops us making the flags argument to gpiod_get*() mandatory.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Sebastian Reichel <sre@kernel.org>

parent f4ed950a

drivers/power/bq25890_charger.c

+1 −6

Original line number	Diff line number	Diff line
		@@ -721,19 +721,14 @@ static int bq25890_usb_notifier(struct notifier_block *nb, unsigned long val,

		static int bq25890_irq_probe(struct bq25890_device *bq)
		{
		int ret;
		struct gpio_desc *irq;

		irq = devm_gpiod_get_index(bq->dev, BQ25890_IRQ_PIN, 0);
		irq = devm_gpiod_get_index(bq->dev, BQ25890_IRQ_PIN, 0, GPIOD_IN);
		if (IS_ERR(irq)) {
		dev_err(bq->dev, "Could not probe irq pin.\n");
		return PTR_ERR(irq);
		}

		ret = gpiod_direction_input(irq);
		if (ret < 0)
		return ret;

		return gpiod_to_irq(irq);
		}