Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ffc548bb authored by Bart Van Assche's avatar Bart Van Assche Committed by Doug Ledford
Browse files

IB/srp: Avoid that mapping failure triggers an infinite loop 



The srp_queuecommand() function translates ENOMEM into QUEUE_FULL
which causes the SCSI mid-layer to retry the command. All other
error codes are translated into DID_ERROR which causes the SCSI
command to fail. Return E2BIG if mapping will always fail to
prevent that the SCSI mid-layer keeps resubmitting a command
forever.

Signed-off-by: default avatarBart Van Assche <bart.vanassche@sandisk.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Sagi Grimberg <sagi@grimberg.me>
Cc: Laurence Oberman <loberman@redhat.com>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
parent fa9863f8

drivers/infiniband/ulp/srp/ib_srp.c

+2 −0
Original line number Diff line number Diff line
@@ -1681,6 +1681,8 @@ static int srp_map_data(struct scsi_cmnd *scmnd, struct srp_rdma_ch *ch, 


unmap:

	srp_unmap_data(scmnd, ch, req);

	if (ret == -ENOMEM && req->nmdesc >= target->mr_pool_size)

		ret = -E2BIG;

	return ret;

}