Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ff3aa88a authored by Stefan Brüns's avatar Stefan Brüns Committed by Jonathan Cameron
Browse files

iio: adc: ina219: Avoid underflow for sleeping time 



Proper support for the INA219 lowered the minimum sampling period from
2*140us to 2*84us. Subtracting 200us later leads to an underflow and
an almost infinite udelay later.

Using a signed int for the sampling period provides sufficient range
(at most 2*8640*1024us), but catches the underflow when comparing with
buffer_us.

Fixes: 18edac2e ("iio: adc: Fix integration time/averaging for INA219/220")
Signed-off-by: default avatarStefan Brüns <stefan.bruens@rwth-aachen.de>
Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent 90938ca4

drivers/iio/adc/ina2xx-adc.c

+1 −1
Original line number Diff line number Diff line
@@ -644,7 +644,7 @@ static int ina2xx_capture_thread(void *data) 
{

	struct iio_dev *indio_dev = data;

	struct ina2xx_chip_info *chip = iio_priv(indio_dev);

	unsigned int sampling_us = SAMPLING_PERIOD(chip);

	int sampling_us = SAMPLING_PERIOD(chip);

	int buffer_us;



	/*