Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ff1f8ca0 authored by Jiri Pirko's avatar Jiri Pirko Committed by David S. Miller
Browse files

net: sched: cls_basic: no need to call tcf_exts_change for newly allocated struct 



As the f struct was allocated right before basic_set_parms call, no need
to use tcf_exts_change to do atomic change, and we can just fill-up
the unused exts struct directly by tcf_exts_validate.

Signed-off-by: default avatarJiri Pirko <jiri@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent a74cb369

net/sched/cls_basic.c

+2 −11
Original line number Diff line number Diff line
@@ -129,31 +129,22 @@ static int basic_set_parms(struct net *net, struct tcf_proto *tp, 
			   struct nlattr *est, bool ovr)

{

	int err;

	struct tcf_exts e;



	err = tcf_exts_init(&e, TCA_BASIC_ACT, TCA_BASIC_POLICE);

	err = tcf_exts_validate(net, tp, tb, est, &f->exts, ovr);

	if (err < 0)

		return err;

	err = tcf_exts_validate(net, tp, tb, est, &e, ovr);

	if (err < 0)

		goto errout;



	err = tcf_em_tree_validate(tp, tb[TCA_BASIC_EMATCHES], &f->ematches);

	if (err < 0)

		goto errout;

		return err;



	if (tb[TCA_BASIC_CLASSID]) {

		f->res.classid = nla_get_u32(tb[TCA_BASIC_CLASSID]);

		tcf_bind_filter(tp, &f->res, base);

	}



	tcf_exts_change(tp, &f->exts, &e);

	f->tp = tp;



	return 0;

errout:

	tcf_exts_destroy(&e);

	return err;

}



static int basic_change(struct net *net, struct sk_buff *in_skb,