Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ff089191 authored by Huy Nguyen's avatar Huy Nguyen Committed by Saeed Mahameed
Browse files

net/mlx5e: Fix ETS BW check 



Fix bug that allows ets bw sum to be 0% when ets tc type exists.

Fixes: 08fb1dac ('net/mlx5e: Support DCBNL IEEE ETS')
Signed-off-by: default avatarMoshe Shemesh <moshe@mellanox.com>
Reviewed-by: default avatarHuy Nguyen <huyn@mellanox.com>
Signed-off-by: default avatarSaeed Mahameed <saeedm@mellanox.com>
parent 37e92a9d

drivers/net/ethernet/mellanox/mlx5/core/en_dcbnl.c

+7 −3
Original line number Diff line number Diff line
@@ -274,6 +274,7 @@ int mlx5e_dcbnl_ieee_setets_core(struct mlx5e_priv *priv, struct ieee_ets *ets) 
static int mlx5e_dbcnl_validate_ets(struct net_device *netdev,

				    struct ieee_ets *ets)

{

	bool have_ets_tc = false;

	int bw_sum = 0;

	int i;
@@ -288,11 +289,14 @@ static int mlx5e_dbcnl_validate_ets(struct net_device *netdev, 
	}



	/* Validate Bandwidth Sum */

	for (i = 0; i < IEEE_8021QAZ_MAX_TCS; i++)

		if (ets->tc_tsa[i] == IEEE_8021QAZ_TSA_ETS)

	for (i = 0; i < IEEE_8021QAZ_MAX_TCS; i++) {

		if (ets->tc_tsa[i] == IEEE_8021QAZ_TSA_ETS) {

			have_ets_tc = true;

			bw_sum += ets->tc_tx_bw[i];

		}

	}



	if (bw_sum != 0 && bw_sum != 100) {

	if (have_ets_tc && bw_sum != 100) {

		netdev_err(netdev,

			   "Failed to validate ETS: BW sum is illegal\n");

		return -EINVAL;