Commit fee8cc87 authored Jul 21, 2016 by wang di Committed by Greg Kroah-Hartman Aug 15, 2016

staging: lustre: llite: handle done flags differently in ll_dir_read



Invert the done flag test to reduce the code indentation.
If done is true release the page and break out of the
while loop.

Signed-off-by: wang di <di.wang@intel.com>
Reviewed-on: http://review.whamcloud.com/10761
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4906


Reviewed-by: John L. Hammond <john.hammond@intel.com>
Reviewed-by: Jinshan Xiong <jinshan.xiong@intel.com>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: James Simmons <jsimmons@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent fb659ca1

drivers/staging/lustre/lustre/llite/dir.c

+30 −29

Original line number	Diff line number	Diff line
		@@ -562,7 +562,12 @@ int ll_dir_read(struct inode inode, struct md_op_data op_data,
		namelen, ino, type);
		}

		if (!done) {
		if (done) {
		pos = hash;
		ll_release_page(page, 0);
		break;
		}

		next = le64_to_cpu(dp->ldp_hash_end);
		pos = next;
		if (pos == MDS_DIR_END_OFF) {
		@@ -590,10 +595,6 @@ int ll_dir_read(struct inode inode, struct md_op_data op_data,
		LDF_COLLIDE);
		ll_release_page(page, 1);
		}
		} else {
		pos = hash;
		ll_release_page(page, 0);
		}
		}

		ctx->pos = pos;