Commit fed67814 authored Feb 06, 2017 by Gabriel Krisman Bertazi Committed by Bjorn Helgaas Feb 10, 2017

PCI: Remove duplicate check for positive return value from probe() functions

Function __pci_device_probe() tries to be careful about a PCI driver
probe() hook returning a positive value, but this is not really necessary,
since the same fix up is already done in local_pci_probe() (preceded by a
noisy warning), which renders this instance dead code.

Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.co.uk>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>

parent 60db3a4d

drivers/pci/pci-driver.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -381,8 +381,6 @@ static int __pci_device_probe(struct pci_driver drv, struct pci_dev pci_dev)
		id = pci_match_device(drv, pci_dev);
		if (id)
		error = pci_call_probe(drv, pci_dev, id);
		if (error >= 0)
		error = 0;
		}
		return error;
		}