Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fed56079 authored by Phil Elwell's avatar Phil Elwell Committed by David S. Miller
Browse files

lan78xx: Avoid spurious kevent 4 "error" 



lan78xx_defer_event generates an error message whenever the work item
is already scheduled. lan78xx_open defers three events -
EVENT_STAT_UPDATE, EVENT_DEV_OPEN and EVENT_LINK_RESET. Being aware
of the likelihood (or certainty) of an error message, the DEV_OPEN
event is added to the set of pending events directly, relying on
the subsequent deferral of the EVENT_LINK_RESET call to schedule the
work.  Take the same precaution with EVENT_STAT_UPDATE to avoid a
totally unnecessary error message.

Signed-off-by: default avatarPhil Elwell <phil@raspberrypi.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 4bfc3380

drivers/net/usb/lan78xx.c

+1 −1
Original line number Diff line number Diff line
@@ -2503,7 +2503,7 @@ static void lan78xx_init_stats(struct lan78xx_net *dev) 
	dev->stats.rollover_max.eee_tx_lpi_transitions = 0xFFFFFFFF;

	dev->stats.rollover_max.eee_tx_lpi_time = 0xFFFFFFFF;



	lan78xx_defer_kevent(dev, EVENT_STAT_UPDATE);

	set_bit(EVENT_STAT_UPDATE, &dev->flags);

}



static int lan78xx_open(struct net_device *net)