Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit feb9a369 authored by Chandana Kishori Chiluveru's avatar Chandana Kishori Chiluveru
Browse files

qcom-geni-se: Correct logic for bus BW vote if Bus driver not ready 



Currently driver voting for bus bandwidth without checking for bus
driver registration. But during clks_off or resources_off() checking
for bus handle and exiting the function without removing added vote.

In this change removing checks in clks_off & resource_off functions
in common driver so that it will balance the list operations which
done as a part of clks_on and resources_on functions
and fix issues related list operations.

Change-Id: Ic0986c706bbd061bcef010a8cfb6e3e4e2e4ab7b
Signed-off-by: default avatarChandana Kishori Chiluveru <cchiluve@codeaurora.org>
parent d7bfaea2

drivers/platform/msm/qcom-geni-se.c

+2 −5
Original line number Original line Diff line number Diff line
@@ -808,8 +808,7 @@ int se_geni_clks_off(struct se_geni_rsc *rsc) 
		return -EINVAL;

		return -EINVAL;





	geni_se_dev = dev_get_drvdata(rsc->wrapper_dev);

	geni_se_dev = dev_get_drvdata(rsc->wrapper_dev);

	if (unlikely(!geni_se_dev || !(geni_se_dev->bus_bw ||

	if (unlikely(!geni_se_dev))

					geni_se_dev->bus_bw_noc)))

		return -ENODEV;

		return -ENODEV;





	clk_disable_unprepare(rsc->se_clk);

	clk_disable_unprepare(rsc->se_clk);
@@ -841,9 +840,7 @@ int se_geni_resources_off(struct se_geni_rsc *rsc) 
		return -EINVAL;

		return -EINVAL;





	geni_se_dev = dev_get_drvdata(rsc->wrapper_dev);

	geni_se_dev = dev_get_drvdata(rsc->wrapper_dev);

	if (unlikely(!geni_se_dev ||

	if (unlikely(!geni_se_dev))

			!(geni_se_dev->bus_bw ||

					geni_se_dev->bus_bw_noc)))

		return -ENODEV;

		return -ENODEV;





	ret = se_geni_clks_off(rsc);

	ret = se_geni_clks_off(rsc);