Commit fe6b2ad9 authored Jan 25, 2016 by Christian König Committed by Alex Deucher Feb 10, 2016

drm/amdgpu: use WARN_ON_ONCE instead of BUG_ON in the SA



Crashing the system doesn't helps at all. Also properly return
-EINVAL if size or alignment are outside valid ranges.

Signed-off-by: Christian König <christian.koenig@amd.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

parent 777dbd45

drivers/gpu/drm/amd/amdgpu/amdgpu_sa.c

+5 −2

Original line number	Diff line number	Diff line
		@@ -321,8 +321,11 @@ int amdgpu_sa_bo_new(struct amdgpu_sa_manager *sa_manager,
		int i, r;
		signed long t;

		BUG_ON(align > sa_manager->align);
		BUG_ON(size > sa_manager->size);
		if (WARN_ON_ONCE(align > sa_manager->align))
		return -EINVAL;

		if (WARN_ON_ONCE(size > sa_manager->size))
		return -EINVAL;

		*sa_bo = kmalloc(sizeof(struct amdgpu_sa_bo), GFP_KERNEL);
		if ((*sa_bo) == NULL) {