Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fe1cfc64 authored by Miaohe Lin's avatar Miaohe Lin Committed by Greg Kroah-Hartman
Browse files

KVM: x86: don't notify userspace IOAPIC on edge-triggered interrupt EOI 



commit 7455a8327674e1a7c9a1f5dd1b0743ab6713f6d1 upstream.

Commit 13db7734 ("KVM: x86: don't notify userspace IOAPIC on edge
EOI") said, edge-triggered interrupts don't set a bit in TMR, which means
that IOAPIC isn't notified on EOI. And var level indicates level-triggered
interrupt.
But commit 3159d36a ("KVM: x86: use generic function for MSI parsing")
replace var level with irq.level by mistake. Fix it by changing irq.level
to irq.trig_mode.

Cc: stable@vger.kernel.org
Fixes: 3159d36a ("KVM: x86: use generic function for MSI parsing")
Signed-off-by: default avatarMiaohe Lin <linmiaohe@huawei.com>
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent ed9e97c3

arch/x86/kvm/irq_comm.c

+1 −1
Original line number Diff line number Diff line
@@ -427,7 +427,7 @@ void kvm_scan_ioapic_routes(struct kvm_vcpu *vcpu, 


			kvm_set_msi_irq(vcpu->kvm, entry, &irq);



			if (irq.level && kvm_apic_match_dest(vcpu, NULL, 0,

			if (irq.trig_mode && kvm_apic_match_dest(vcpu, NULL, 0,

						irq.dest_id, irq.dest_mode))

				__set_bit(irq.vector, ioapic_handled_vectors);

		}