Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fdbb9457 authored by Markus Elfring's avatar Markus Elfring Committed by Michael Ellerman
Browse files

axonram: Return directly after a failed kzalloc() in axon_ram_probe() 



* Return directly after a call of the function "kzalloc" failed
  at the beginning.

* Delete a repeated check for the local variable "bank"
  which became unnecessary with this refactoring.

Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
parent a1bddf39

arch/powerpc/sysdev/axonram.c

+17 −22
Original line number Diff line number Diff line
@@ -192,10 +192,8 @@ static int axon_ram_probe(struct platform_device *device) 
			device->dev.of_node);



	bank = kzalloc(sizeof(*bank), GFP_KERNEL);

	if (bank == NULL) {

		rc = -ENOMEM;

		goto failed;

	}

	if (!bank)

		return -ENOMEM;



	device->dev.platform_data = bank;
@@ -291,7 +289,6 @@ static int axon_ram_probe(struct platform_device *device) 
	return 0;



failed:

	if (bank != NULL) {

	if (bank->irq_id)

		free_irq(bank->irq_id, device);

	if (bank->disk != NULL) {
@@ -308,8 +305,6 @@ static int axon_ram_probe(struct platform_device *device) 
	if (bank->io_addr != 0)

		iounmap((void __iomem *) bank->io_addr);

	kfree(bank);

	}



	return rc;

}