Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fd8e7af8 authored by Russell King's avatar Russell King Committed by Russell King
Browse files

[ARM] pxa: Avoid fiddling with CKEN register on suspend 



The PXA manuals indicate that when in standby or sleep modes, clocks to
peripherals are shut off by the processor itself.  Eg:

PXA270 standby: "In standby mode, all clocks are disabled except those
 for the power manager and the RTC."

PXA270 sleep: "In sleep mode, all clocks are disabled to the processor
 and to all peripherals except the RTC."

PXA255 sleep: "In Sleep Mode, all processor and peripheral clocks are
 disabled, except the RTC."

Therefore, it should be safe to leave the clock enable register alone
prior to entering low power modes for these SoCs.

Signed-off-by: default avatarRussell King <rmk+kernel@arm.linux.org.uk>
parent 7b5dea12

arch/arm/mach-pxa/pxa25x.c

+0 −2
Original line number Diff line number Diff line
@@ -216,8 +216,6 @@ static void pxa25x_cpu_pm_restore(unsigned long *sleep_save) 


static void pxa25x_cpu_pm_enter(suspend_state_t state)

{

	CKEN = 0;



	switch (state) {

	case PM_SUSPEND_MEM:

		/* set resume return address */

arch/arm/mach-pxa/pxa27x.c

+0 −6
Original line number Diff line number Diff line
@@ -265,12 +265,6 @@ void pxa27x_cpu_pm_enter(suspend_state_t state) 
{

	extern void pxa_cpu_standby(void);



	if (state == PM_SUSPEND_STANDBY)

		CKEN = (1 << CKEN_MEMC) | (1 << CKEN_OSTIMER) |

			(1 << CKEN_LCD) | (1 << CKEN_PWM0);

	else

		CKEN = (1 << CKEN_MEMC) | (1 << CKEN_OSTIMER);



	/* ensure voltage-change sequencer not initiated, which hangs */

	PCFR &= ~PCFR_FVC;