Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fd5bdcf6 authored by Pietro Borrello's avatar Pietro Borrello Committed by Gerrit - the friendly Code Review server
Browse files

tun: tun_chr_open(): correctly initialize socket uid



sock_init_data() assumes that the `struct socket` passed in input is
contained in a `struct socket_alloc` allocated with sock_alloc().
However, tun_chr_open() passes a `struct socket` embedded in a `struct
tun_file` allocated with sk_alloc().
This causes a type confusion when issuing a container_of() with
SOCK_INODE() in sock_init_data() which results in assigning a wrong
sk_uid to the `struct sock` in input.
On default configuration, the type confused field overlaps with the
high 4 bytes of `struct tun_struct __rcu *tun` of `struct tun_file`,
NULL at the time of call, which makes the uid of all tun sockets 0,
i.e., the root one.
Fix the assignment by using sock_init_data_uid().

Change-Id: I35083661319d08475fbba716d228758e5355c36f
Fixes: 86741ec2 ("net: core: Add a UID field to struct sock.")
Signed-off-by: default avatarPietro Borrello <borrello@diag.uniroma1.it>
Reviewed-by: default avatarEric Dumazet <edumazet@google.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Git-commit: a096ccca6e503a5c575717ff8a36ace27510ab0a
Git-repo: https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git


Signed-off-by: default avatarKaustubh Pandey <quic_kapandey@quicinc.com>
parent 9e36bbbd
Loading
Loading
Loading
Loading
+1 −1
Original line number Diff line number Diff line
@@ -3257,7 +3257,7 @@ static int tun_chr_open(struct inode *inode, struct file * file)
	tfile->socket.file = file;
	tfile->socket.ops = &tun_socket_ops;

	sock_init_data(&tfile->socket, &tfile->sk);
	sock_init_data_uid(&tfile->socket, &tfile->sk, inode->i_uid);

	tfile->sk.sk_write_space = tun_sock_write_space;
	tfile->sk.sk_sndbuf = INT_MAX;