Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fcf1fadf authored by Xidong Wang's avatar Xidong Wang Committed by Joonas Lahtinen
Browse files

drm/i915: Do no use kfree() to free a kmem_cache_alloc() return value 



Along the eb_lookup_vmas() error path, the return value from
kmem_cache_alloc() was freed using kfree(). Fix it to use the proper
kmem_cache_free() instead.

Fixes: d1b48c1e ("drm/i915: Replace execbuf vma ht with an idr")
Signed-off-by: default avatarXidong Wang <wangxidong_97@163.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: <stable@vger.kernel.org> # v4.14+
Reviewed-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
Link: https://patchwork.freedesktop.org/patch/msgid/20180404093824.9313-1-chris@chris-wilson.co.uk


(cherry picked from commit 6be1187d)
Signed-off-by: default avatarJoonas Lahtinen <joonas.lahtinen@linux.intel.com>
parent 38057aa1

drivers/gpu/drm/i915/i915_gem_execbuffer.c

+1 −1
Original line number Diff line number Diff line
@@ -728,7 +728,7 @@ static int eb_lookup_vmas(struct i915_execbuffer *eb) 


		err = radix_tree_insert(handles_vma, handle, vma);

		if (unlikely(err)) {

			kfree(lut);

			kmem_cache_free(eb->i915->luts, lut);

			goto err_obj;

		}