Commit fca288c0 authored Mar 15, 2018 by Dexuan Cui Committed by Lorenzo Pieralisi Mar 16, 2018

PCI: hv: Remove the bogus test in hv_eject_device_work()



When kernel is executing hv_eject_device_work(), hpdev->state value must
be hv_pcichild_ejecting; any other value would consist in a bug,
therefore replace the bogus check with an explicit WARN_ON() on the
condition failure detection.

Signed-off-by: Dexuan Cui <decui@microsoft.com>
[lorenzo.pieralisi@arm.com: updated commit log]
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Reviewed-by: Michael Kelley <mikelley@microsoft.com>
Acked-by: Haiyang Zhang <haiyangz@microsoft.com>
Cc: Vitaly Kuznetsov <vkuznets@redhat.com>
Cc: Jack Morgenstein <jackm@mellanox.com>
Cc: Stephen Hemminger <sthemmin@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>

parent df3f2159

drivers/pci/host/pci-hyperv.c

+1 −4

Original line number	Diff line number	Diff line
		@@ -1842,10 +1842,7 @@ static void hv_eject_device_work(struct work_struct *work)

		hpdev = container_of(work, struct hv_pci_dev, wrk);

		if (hpdev->state != hv_pcichild_ejecting) {
		put_pcichild(hpdev, hv_pcidev_ref_pnp);
		return;
		}
		WARN_ON(hpdev->state != hv_pcichild_ejecting);

		/*
		* Ejection can come before or after the PCI bus has been set up, so