Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fc916ff2 authored by Sudarsana Reddy Kalluru's avatar Sudarsana Reddy Kalluru Committed by David S. Miller
Browse files

qed: Prevent MF link notifications 



When device is configured for Multi-function mode, some older management
firmware might incorrectly notify interfaces of link changes while they
haven't requested the physical link configuration to be set.
This can create bizzare race conditions where unloading interfaces are
getting notified that the link is up.

Let the driver compensate - store the logical requested state of the link
and don't propagate notifications after protocol driver explicitly
requires the link to be unset.

Signed-off-by: default avatarSudarsana Reddy Kalluru <sudarsana.kalluru@qlogic.com>
Signed-off-by: default avatarYuval Mintz <Yuval.Mintz@qlogic.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 627caa9d

drivers/net/ethernet/qlogic/qed/qed.h

+3 −0
Original line number Diff line number Diff line
@@ -303,6 +303,9 @@ struct qed_hwfn { 
	bool				b_int_enabled;

	bool				b_int_requested;



	/* True if the driver requests for the link */

	bool				b_drv_link_init;



	struct qed_mcp_info		*mcp_info;



	struct qed_hw_cid_data		*p_tx_cids;

drivers/net/ethernet/qlogic/qed/qed_mcp.c

+6 −1
Original line number Diff line number Diff line
@@ -390,7 +390,10 @@ static void qed_mcp_handle_link_change(struct qed_hwfn *p_hwfn, 
		return;

	}



	if (p_hwfn->b_drv_link_init)

		p_link->link_up = !!(status & LINK_STATUS_LINK_UP);

	else

		p_link->link_up = false;



	p_link->full_duplex = true;

	switch ((status & LINK_STATUS_SPEED_AND_DUPLEX_MASK)) {
@@ -520,6 +523,8 @@ int qed_mcp_set_link(struct qed_hwfn *p_hwfn, 
		       offsetof(struct public_drv_mb, union_data) + i,

		       ((u32 *)&phy_cfg)[i >> 2]);



	p_hwfn->b_drv_link_init = b_up;



	if (b_up) {

		DP_VERBOSE(p_hwfn, NETIF_MSG_LINK,

			   "Configuring Link: Speed 0x%08x, Pause 0x%08x, adv_speed 0x%08x, loopback 0x%08x, features 0x%08x\n",