Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fc38279e authored by Yi Wang's avatar Yi Wang Committed by Greg Kroah-Hartman
Browse files

fork: fix some -Wmissing-prototypes warnings 

[ Upstream commit fb5bf31722d0805a3f394f7d59f2e8cd07acccb7 ]

We get a warning when building kernel with W=1:

  kernel/fork.c:167:13: warning: no previous prototype for `arch_release_thread_stack' [-Wmissing-prototypes]
  kernel/fork.c:779:13: warning: no previous prototype for `fork_init' [-Wmissing-prototypes]

Add the missing declaration in head file to fix this.

Also, remove arch_release_thread_stack() completely because no arch
seems to implement it since bb9d8126 (arch: remove tile port).

Link: http://lkml.kernel.org/r/1542170087-23645-1-git-send-email-wang.yi59@zte.com.cn


Signed-off-by: default avatarYi Wang <wang.yi59@zte.com.cn>
Acked-by: default avatarMichal Hocko <mhocko@suse.com>
Acked-by: default avatarMike Rapoport <rppt@linux.ibm.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 0321fe1c

include/linux/sched/task.h

+2 −0
Original line number Diff line number Diff line
@@ -39,6 +39,8 @@ void __noreturn do_task_dead(void); 


extern void proc_caches_init(void);



extern void fork_init(void);



extern void release_task(struct task_struct * p);



#ifdef CONFIG_HAVE_COPY_THREAD_TLS

init/main.c

+0 −1
Original line number Diff line number Diff line
@@ -105,7 +105,6 @@ 
static int kernel_init(void *);



extern void init_IRQ(void);

extern void fork_init(void);

extern void radix_tree_init(void);



/*

kernel/fork.c

+0 −5
Original line number Diff line number Diff line
@@ -163,10 +163,6 @@ static inline void free_task_struct(struct task_struct *tsk) 
}

#endif



void __weak arch_release_thread_stack(unsigned long *stack)

{

}



#ifndef CONFIG_ARCH_THREAD_STACK_ALLOCATOR



/*
@@ -376,7 +372,6 @@ static void release_task_stack(struct task_struct *tsk) 
		return;  /* Better to leak the stack than to free prematurely */



	account_kernel_stack(tsk, -1);

	arch_release_thread_stack(tsk->stack);

	free_thread_stack(tsk);

	tsk->stack = NULL;

#ifdef CONFIG_VMAP_STACK