Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fc0c3dd1 authored by Benny Halevy's avatar Benny Halevy Committed by J. Bruce Fields
Browse files

nfsd4: seq->status_flags may be used unitialized 



Reported-by: default avatarGopala Suryanarayana <gsuryanarayana@vmware.com>
Signed-off-by: default avatarBenny Halevy <bhalevy@tonian.com>
Signed-off-by: default avatarJ. Bruce Fields <bfields@redhat.com>
parent 5423732a

fs/nfsd/nfs4state.c

+4 −2
Original line number Original line Diff line number Diff line
@@ -1947,11 +1947,13 @@ nfsd4_sequence(struct svc_rqst *rqstp, 
		atomic_inc(&clp->cl_refcount);

		atomic_inc(&clp->cl_refcount);

		switch (clp->cl_cb_state) {

		switch (clp->cl_cb_state) {

		case NFSD4_CB_DOWN:

		case NFSD4_CB_DOWN:

			seq->status_flags |= SEQ4_STATUS_CB_PATH_DOWN;

			seq->status_flags = SEQ4_STATUS_CB_PATH_DOWN;

			break;

			break;

		case NFSD4_CB_FAULT:

		case NFSD4_CB_FAULT:

			seq->status_flags |= SEQ4_STATUS_BACKCHANNEL_FAULT;

			seq->status_flags = SEQ4_STATUS_BACKCHANNEL_FAULT;

			break;

			break;

		default:

			seq->status_flags = 0;

		}

		}

	}

	}

	kfree(conn);

	kfree(conn);