Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fc0012ec authored by Ondrej Zary's avatar Ondrej Zary Committed by Tejun Heo
Browse files

pata_isapnp: Don't use invalid I/O ports 



The test for 2nd I/O port validity is broken (reversed): On devices
with no control port, the driver attempts to use invalid port 0,
resulting in logs full of bad_io_access errors.  On devices with
control port, the driver does not use it.

Signed-off-by: default avatarOndrej Zary <linux@rainbow-software.org>
Signed-off-by: default avatarTejun Heo <tj@kernel.org>
parent 272b98c6

drivers/ata/pata_isapnp.c

+1 −1
Original line number Diff line number Diff line
@@ -78,7 +78,7 @@ static int isapnp_init_one(struct pnp_dev *idev, const struct pnp_device_id *dev 


	ap->ioaddr.cmd_addr = cmd_addr;



	if (pnp_port_valid(idev, 1) == 0) {

	if (pnp_port_valid(idev, 1)) {

		ctl_addr = devm_ioport_map(&idev->dev,

					   pnp_port_start(idev, 1), 1);

		ap->ioaddr.altstatus_addr = ctl_addr;