Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fbcd253d authored by Florian Westphal's avatar Florian Westphal Committed by Pablo Neira Ayuso
Browse files

netfilter: conntrack: lower timeout to RETRANS seconds if window is 0 



When zero window is announced we can get into a situation where
connection stays around forever:

1. One side announces zero window.
2. Other side closes.

In this case, no FIN is sent (stuck in send queue).

Unless other side opens the window up again conntrack
stays in ESTABLISHED state for a very long time.

Lets alleviate this by lowering the timeout to RETRANS (5 minutes),
the other end should be sending zero window probes to keep the
connection established as long as a socket still exists.

Cc: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>
Signed-off-by: default avatarFlorian Westphal <fw@strlen.de>
Acked-by: default avatarJozsef Kadlecsik <kadlec@blackhole.kfki.hu>
Signed-off-by: default avatarPablo Neira Ayuso <pablo@netfilter.org>
parent ec8a8f3c

net/netfilter/nf_conntrack_proto_tcp.c

+3 −0
Original line number Diff line number Diff line
@@ -1039,6 +1039,9 @@ static int tcp_packet(struct nf_conn *ct, 
		 IP_CT_TCP_FLAG_DATA_UNACKNOWLEDGED &&

		 timeouts[new_state] > timeouts[TCP_CONNTRACK_UNACK])

		timeout = timeouts[TCP_CONNTRACK_UNACK];

	else if (ct->proto.tcp.last_win == 0 &&

		 timeouts[new_state] > timeouts[TCP_CONNTRACK_RETRANS])

		timeout = timeouts[TCP_CONNTRACK_RETRANS];

	else

		timeout = timeouts[new_state];

	spin_unlock_bh(&ct->lock);