Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fbc80823 authored by Giuseppe Cavallaro's avatar Giuseppe Cavallaro Committed by David S. Miller
Browse files

stmmac: set dirty index out of the loop 



The dirty index can be updated out of the loop where all the
tx resources are claimed. This will help on performances too.
Also a useless debug printk has been removed from the main loop.

Signed-off-by: default avatarGiuseppe Cavallaro <peppe.cavallaro@st.com>
Signed-off-by: default avatarAlexandre TORGUE <alexandre.torgue@st.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent c363b658

drivers/net/ethernet/stmicro/stmmac/stmmac_main.c

+1 −4
Original line number Diff line number Diff line
@@ -1340,9 +1340,6 @@ static void stmmac_tx_clean(struct stmmac_priv *priv) 
			}

			stmmac_get_tx_hwtstamp(priv, entry, skb);

		}

		if (netif_msg_tx_done(priv))

			pr_debug("%s: curr %d, dirty %d\n", __func__,

				 priv->cur_tx, priv->dirty_tx);



		if (likely(priv->tx_skbuff_dma[entry].buf)) {

			if (priv->tx_skbuff_dma[entry].map_as_page)
@@ -1372,8 +1369,8 @@ static void stmmac_tx_clean(struct stmmac_priv *priv) 
		priv->hw->desc->release_tx_desc(p, priv->mode);



		entry = STMMAC_GET_ENTRY(entry, DMA_TX_SIZE);

		priv->dirty_tx = entry;

	}

	priv->dirty_tx = entry;



	netdev_completed_queue(priv->dev, pkts_compl, bytes_compl);