Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fb29b57c authored by Felix Kuehling's avatar Felix Kuehling Committed by Alex Deucher
Browse files

drm/amdgpu: Fix two bugs in amdgpu_vm_bo_split_mapping 



Off-by-one: last is inclusive, so the maximum is start + max_size - 1
Wrong unit: addr is in bytes, max_size is in pages

Signed-off-by: default avatarFelix Kuehling <Felix.Kuehling@amd.com>
Reviewed-by: default avatarChristian König <christian.koenig@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 459ee1c3

drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c

+2 −2
Original line number Diff line number Diff line
@@ -867,7 +867,7 @@ static int amdgpu_vm_bo_split_mapping(struct amdgpu_device *adev, 
	while (start != mapping->it.last + 1) {

		uint64_t last;



		last = min((uint64_t)mapping->it.last, start + max_size);

		last = min((uint64_t)mapping->it.last, start + max_size - 1);

		r = amdgpu_vm_bo_update_mapping(adev, gtt, gtt_flags, vm,

						start, last, flags, addr,

						fence);
@@ -875,7 +875,7 @@ static int amdgpu_vm_bo_split_mapping(struct amdgpu_device *adev, 
			return r;



		start = last + 1;

		addr += max_size;

		addr += max_size * AMDGPU_GPU_PAGE_SIZE;

	}



	return 0;