Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fb01bfda authored by Akinobu Mita's avatar Akinobu Mita Committed by Linus Torvalds
Browse files

ext[234]: remove unused argument for ext[234]_find_goal() 



The argument chain for ext[234]_find_goal() is not used.  This patch removes
it and fixes comment as well.

Cc: <linux-ext4@vger.kernel.org>
Signed-off-by: default avatarAkinobu Mita <akinobu.mita@gmail.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 197cd65a

fs/ext2/inode.c

+2 −5
Original line number Diff line number Diff line
@@ -286,15 +286,12 @@ static unsigned long ext2_find_near(struct inode *inode, Indirect *ind) 
 *	ext2_find_goal - find a prefered place for allocation.

 *	@inode: owner

 *	@block:  block we want

 *	@chain:  chain of indirect blocks

 *	@partial: pointer to the last triple within a chain

 *

 *	Returns preferred place for a block (the goal).

 */



static inline int ext2_find_goal(struct inode *inode,

				 long block,

				 Indirect chain[4],

static inline int ext2_find_goal(struct inode *inode, long block,

				 Indirect *partial)

{

	struct ext2_block_alloc_info *block_i;
@@ -638,7 +635,7 @@ static int ext2_get_blocks(struct inode *inode, 
	if (S_ISREG(inode->i_mode) && (!ei->i_block_alloc_info))

		ext2_init_block_alloc_info(inode);



	goal = ext2_find_goal(inode, iblock, chain, partial);

	goal = ext2_find_goal(inode, iblock, partial);



	/* the number of blocks need to allocate for [d,t]indirect blocks */

	indirect_blks = (chain + depth) - partial - 1;

fs/ext3/inode.c

+3 −5
Original line number Diff line number Diff line
@@ -439,16 +439,14 @@ static ext3_fsblk_t ext3_find_near(struct inode *inode, Indirect *ind) 
 *	ext3_find_goal - find a prefered place for allocation.

 *	@inode: owner

 *	@block:  block we want

 *	@chain:  chain of indirect blocks

 *	@partial: pointer to the last triple within a chain

 *	@goal:	place to store the result.

 *

 *	Normally this function find the prefered place for block allocation,

 *	stores it in *@goal and returns zero.

 *	returns it.

 */



static ext3_fsblk_t ext3_find_goal(struct inode *inode, long block,

		Indirect chain[4], Indirect *partial)

				   Indirect *partial)

{

	struct ext3_block_alloc_info *block_i;
@@ -884,7 +882,7 @@ int ext3_get_blocks_handle(handle_t *handle, struct inode *inode, 
	if (S_ISREG(inode->i_mode) && (!ei->i_block_alloc_info))

		ext3_init_block_alloc_info(inode);



	goal = ext3_find_goal(inode, iblock, chain, partial);

	goal = ext3_find_goal(inode, iblock, partial);



	/* the number of blocks need to allocate for [d,t]indirect blocks */

	indirect_blks = (chain + depth) - partial - 1;

fs/ext4/inode.c

+3 −6
Original line number Diff line number Diff line
@@ -429,16 +429,13 @@ static ext4_fsblk_t ext4_find_near(struct inode *inode, Indirect *ind) 
 *	ext4_find_goal - find a prefered place for allocation.

 *	@inode: owner

 *	@block:  block we want

 *	@chain:  chain of indirect blocks

 *	@partial: pointer to the last triple within a chain

 *	@goal:	place to store the result.

 *

 *	Normally this function find the prefered place for block allocation,

 *	stores it in *@goal and returns zero.

 *	returns it.

 */



static ext4_fsblk_t ext4_find_goal(struct inode *inode, ext4_lblk_t block,

		Indirect chain[4], Indirect *partial)

		Indirect *partial)

{

	struct ext4_block_alloc_info *block_i;
@@ -839,7 +836,7 @@ int ext4_get_blocks_handle(handle_t *handle, struct inode *inode, 
	if (S_ISREG(inode->i_mode) && (!ei->i_block_alloc_info))

		ext4_init_block_alloc_info(inode);



	goal = ext4_find_goal(inode, iblock, chain, partial);

	goal = ext4_find_goal(inode, iblock, partial);



	/* the number of blocks need to allocate for [d,t]indirect blocks */

	indirect_blks = (chain + depth) - partial - 1;