Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit faac0ff0 authored by Colin Ian King's avatar Colin Ian King Committed by David S. Miller
Browse files

mlxsw: spectrum: remove redundant check if err is zero 



There is an earlier check and return if err is non-zero, so
the check to see if it is zero is redundant in every iteration
of the loop and hence the check can be removed.

Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Acked-by: default avatarJiri Pirko <jiri@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 7f8c2865

drivers/net/ethernet/mellanox/mlxsw/spectrum.c

+1 −1
Original line number Diff line number Diff line
@@ -1664,7 +1664,7 @@ static void __mlxsw_sp_port_get_stats(struct net_device *dev, 
		return;

	mlxsw_sp_port_get_stats_raw(dev, grp, prio, ppcnt_pl);

	for (i = 0; i < len; i++)

		data[data_index + i] = !err ? hw_stats[i].getter(ppcnt_pl) : 0;

		data[data_index + i] = hw_stats[i].getter(ppcnt_pl);

}



static void mlxsw_sp_port_get_stats(struct net_device *dev,