Commit fa04b769 authored Feb 13, 2017 by Bjorn Andersson

rpmsg: rpmsg_create_ept() returns NULL on error



The parameter validation incorrectly returned an ERR_PTR(), which is not
handled by the callers to rpmsg_create_ept(), per the definition NULL
should be returned.

Fixes: 93e93244 ("rpmsg: Handle invalid parameters in public API")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>

parent 88e30752

drivers/rpmsg/rpmsg_core.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -72,7 +72,7 @@ struct rpmsg_endpoint rpmsg_create_ept(struct rpmsg_device rpdev,
		struct rpmsg_channel_info chinfo)
		{
		if (WARN_ON(!rpdev))
		return ERR_PTR(-EINVAL);
		return NULL;

		return rpdev->ops->create_ept(rpdev, cb, priv, chinfo);
		}