Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f984d94c authored by Sujith's avatar Sujith Committed by John W. Linville
Browse files

ath9k_htc: Fix HTC layer memleak 



Messages that are generated by the HTC layer
don't have any TX callback endpoints assigned to them.
Consequently, the allocated SKBs are never freed.

Fix this issue by handling this case in the HTC layer
itself.

Signed-off-by: default avatarSujith <Sujith.Manoharan@atheros.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 6f0f2669

drivers/net/wireless/ath/ath9k/htc_hst.c

+7 −0
Original line number Diff line number Diff line
@@ -326,11 +326,13 @@ void ath9k_htc_txcompletion_cb(struct htc_target *htc_handle, 
	if (htc_handle->htc_flags & HTC_OP_CONFIG_PIPE_CREDITS) {

		complete(&htc_handle->cmd_wait);

		htc_handle->htc_flags &= ~HTC_OP_CONFIG_PIPE_CREDITS;

		goto ret;

	}



	if (htc_handle->htc_flags & HTC_OP_START_WAIT) {

		complete(&htc_handle->cmd_wait);

		htc_handle->htc_flags &= ~HTC_OP_START_WAIT;

		goto ret;

	}



	if (skb) {
@@ -343,6 +345,11 @@ void ath9k_htc_txcompletion_cb(struct htc_target *htc_handle, 
						  htc_hdr->endpoint_id, txok);

		}

	}



	return;

ret:

	/* HTC-generated packets are freed here. */

	dev_kfree_skb_any(skb);

}



/*