Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f97bec56 authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Greg Kroah-Hartman
Browse files

net: mdio: thunder: Fix a double free issue in the .remove function 



[ Upstream commit a93a0a15876d2a077a3bc260b387d2457a051f24 ]

'bus->mii_bus' have been allocated with 'devm_mdiobus_alloc_size()' in the
probe function. So it must not be freed explicitly or there will be a
double free.

Remove the incorrect 'mdiobus_free' in the remove function.

Fixes: 379d7ac7 ("phy: mdio-thunder: Add driver for Cavium Thunder SoC MDIO buses.")
Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: default avatarRussell King <rmk+kernel@armlinux.org.uk>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 15102886

drivers/net/phy/mdio-thunder.c

+0 −1
Original line number Diff line number Diff line
@@ -129,7 +129,6 @@ static void thunder_mdiobus_pci_remove(struct pci_dev *pdev) 
			continue;



		mdiobus_unregister(bus->mii_bus);

		mdiobus_free(bus->mii_bus);

		oct_mdio_writeq(0, bus->register_base + SMI_EN);

	}

	pci_set_drvdata(pdev, NULL);