Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f97beb53 authored by Jonathan Cameron's avatar Jonathan Cameron Committed by Greg Kroah-Hartman
Browse files

staging:iio:resolver:ad2s1210 drop raw config register access 



This should never have been exposed to userspace

Signed-off-by: default avatarJonathan Cameron <jic23@cam.ac.uk>
Acked-by: default avatarMichael Hennerich <michael.hennerich@analog.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 29148543

drivers/staging/iio/resolver/ad2s1210.c

+0 −44
Original line number Diff line number Diff line
@@ -195,47 +195,6 @@ static inline int ad2s1210_soft_reset(struct ad2s1210_state *st) 
	return ad2s1210_config_write(st, 0x0);

}





/* return the OLD DATA since last spi bus write */

static ssize_t ad2s1210_show_raw(struct device *dev,

				 struct device_attribute *attr,

				 char *buf)

{

	struct ad2s1210_state *st = iio_priv(dev_get_drvdata(dev));

	int ret = 0;



	mutex_lock(&st->lock);

	if (st->old_data) {

		ret = sprintf(buf, "0x%x\n", st->rx[0]);

		st->old_data = false;

	}

	mutex_unlock(&st->lock);



	return ret;

}



static ssize_t ad2s1210_store_raw(struct device *dev,

				  struct device_attribute *attr,

				  const char *buf,

				  size_t len)

{

	struct ad2s1210_state *st = iio_priv(dev_get_drvdata(dev));

	unsigned long udata;

	unsigned char data;

	int ret;



	ret = strict_strtoul(buf, 16, &udata);

	if (ret)

		return -EINVAL;



	data = udata & 0xff;

	mutex_lock(&st->lock);

	ret = ad2s1210_config_write(st, data);

	mutex_unlock(&st->lock);



	return ret < 0 ? ret : len;

}



static ssize_t ad2s1210_store_softreset(struct device *dev,

					struct device_attribute *attr,

					const char *buf,
@@ -580,8 +539,6 @@ static int ad2s1210_read_raw(struct iio_dev *indio_dev, 
	return ret;

}



static IIO_DEVICE_ATTR(raw_io, S_IRUGO | S_IWUSR,

		       ad2s1210_show_raw, ad2s1210_store_raw, 0);

static IIO_DEVICE_ATTR(reset, S_IWUSR,

		       NULL, ad2s1210_store_softreset, 0);

static IIO_DEVICE_ATTR(fclkin, S_IRUGO | S_IWUSR,
@@ -631,7 +588,6 @@ static struct iio_chan_spec ad2s1210_channels[] = { 
};



static struct attribute *ad2s1210_attributes[] = {

	&iio_dev_attr_raw_io.dev_attr.attr,

	&iio_dev_attr_reset.dev_attr.attr,

	&iio_dev_attr_fclkin.dev_attr.attr,

	&iio_dev_attr_fexcit.dev_attr.attr,