Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f8db3c90 authored by Wei Yongjun's avatar Wei Yongjun Committed by Bjorn Helgaas
Browse files

PCI: exynos: Add missing clk_disable_unprepare() on error path 



Add the missing clk_disable_unprepare() before return
from exynos_pcie_probe() in the error handling case.

Signed-off-by: default avatarWei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Acked-by: default avatarJingoo Han <jg1.han@samsung.com>
parent f62b878b

drivers/pci/host/pci-exynos.c

+12 −6
Original line number Diff line number Diff line
@@ -599,18 +599,24 @@ static int __init exynos_pcie_probe(struct platform_device *pdev) 


	elbi_base = platform_get_resource(pdev, IORESOURCE_MEM, 0);

	exynos_pcie->elbi_base = devm_ioremap_resource(&pdev->dev, elbi_base);

	if (IS_ERR(exynos_pcie->elbi_base))

		return PTR_ERR(exynos_pcie->elbi_base);

	if (IS_ERR(exynos_pcie->elbi_base)) {

		ret = PTR_ERR(exynos_pcie->elbi_base);

		goto fail_bus_clk;

	}



	phy_base = platform_get_resource(pdev, IORESOURCE_MEM, 1);

	exynos_pcie->phy_base = devm_ioremap_resource(&pdev->dev, phy_base);

	if (IS_ERR(exynos_pcie->phy_base))

		return PTR_ERR(exynos_pcie->phy_base);

	if (IS_ERR(exynos_pcie->phy_base)) {

		ret = PTR_ERR(exynos_pcie->phy_base);

		goto fail_bus_clk;

	}



	block_base = platform_get_resource(pdev, IORESOURCE_MEM, 2);

	exynos_pcie->block_base = devm_ioremap_resource(&pdev->dev, block_base);

	if (IS_ERR(exynos_pcie->block_base))

		return PTR_ERR(exynos_pcie->block_base);

	if (IS_ERR(exynos_pcie->block_base)) {

		ret = PTR_ERR(exynos_pcie->block_base);

		goto fail_bus_clk;

	}



	ret = add_pcie_port(pp, pdev);

	if (ret < 0)