Commit f89e49e7 authored Sep 06, 2010 by Anton Blanchard Committed by David S. Miller Sep 06, 2010

ibmveth: Use lighter weight read memory barrier in ibmveth_poll



We want to order the read in ibmveth_rxq_pending_buffer and the read of
ibmveth_rxq_buffer_valid which are both cacheable memory. smp_rmb() is good
enough for this.

Signed-off-by: Anton Blanchard <anton@samba.org>
Signed-off-by: Santiago Leon <santil@linux.vnet.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 8d86c61a

drivers/net/ibmveth.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -1010,7 +1010,7 @@ static int ibmveth_poll(struct napi_struct *napi, int budget)
	if (!ibmveth_rxq_pending_buffer(adapter))		if (!ibmveth_rxq_pending_buffer(adapter))
	break;		break;

	rmb();		smp_rmb();
	if (!ibmveth_rxq_buffer_valid(adapter)) {		if (!ibmveth_rxq_buffer_valid(adapter)) {
	wmb(); /* suggested by larson1 */		wmb(); /* suggested by larson1 */
	adapter->rx_invalid_buffer++;		adapter->rx_invalid_buffer++;