Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f831f6b8 authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Greg Kroah-Hartman
Browse files

usb: gadget: pch_udc: fix use after free 



commit 66d1b0c0580b7f1b1850ee4423f32ac42afa2e92 upstream.

Remove pointer dereference after free.

pci_pool_free doesn't care about contents of td.
It's just a void* for it

Addresses-Coverity-ID: 1091173 ("Use after free")
Cc: stable@vger.kernel.org
Acked-by: default avatarMichal Nazarewicz <mina86@mina86.com>
Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
Link: https://lore.kernel.org/r/20191106202821.GA20347@embeddedor


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 2a030dbe

drivers/usb/gadget/udc/pch_udc.c

+0 −1
Original line number Diff line number Diff line
@@ -1520,7 +1520,6 @@ static void pch_udc_free_dma_chain(struct pch_udc_dev *dev, 
		td = phys_to_virt(addr);

		addr2 = (dma_addr_t)td->next;

		dma_pool_free(dev->data_requests, td, addr);

		td->next = 0x00;

		addr = addr2;

	}

	req->chain_len = 1;