Commit f823a2aa authored Jul 18, 2016 by Florian Fainelli Committed by Kalle Valo Jul 19, 2016

brcmsmac: Initialize power in brcms_c_stf_ss_algo_channel_get()



wlc_phy_txpower_get_current() does a logical OR of power->flags, which
presumes that power.flags was initiliazed earlier by the caller,
unfortunately, this is not the case, so make sure we zero out the struct
tx_power before calling into wlc_phy_txpower_get_current().

Reported-by: coverity (CID 146011)
Fixes: 5b435de0 ("net: wireless: add brcm80211 drivers")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

parent 5c5fa1f4

drivers/net/wireless/broadcom/brcm80211/brcmsmac/stf.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -87,7 +87,7 @@ void
		brcms_c_stf_ss_algo_channel_get(struct brcms_c_info wlc, u16 ss_algo_channel,
		u16 chanspec)
		{
		struct tx_power power;
		struct tx_power power = { };
		u8 siso_mcs_id, cdd_mcs_id, stbc_mcs_id;

		/* Clear previous settings */